-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResizableBox: Remove knobs in stories #46774
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
74d0ac4
ResizableBox: Remove knobs in stories
mirka e2919e9
Show more props from types
mirka 05dba41
Remove unimportant prop controls
mirka 7cd7eab
Always enable `enable` prop
mirka f2f6f16
Remove `parseInt()` from readme code snippet
mirka 4cc4395
Hide control for `children` prop
mirka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import type { ComponentMeta, ComponentStory } from '@storybook/react'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import ResizableBox from '..'; | ||
|
||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useState } from '@wordpress/element'; | ||
|
||
const meta: ComponentMeta< typeof ResizableBox > = { | ||
title: 'Components/ResizableBox', | ||
component: ResizableBox, | ||
argTypes: { | ||
children: { control: { type: null } }, | ||
enable: { control: 'object' }, | ||
onResizeStop: { action: 'onResizeStop' }, | ||
}, | ||
parameters: { | ||
controls: { expanded: true }, | ||
docs: { source: { state: 'open' } }, | ||
}, | ||
}; | ||
export default meta; | ||
|
||
const Template: ComponentStory< typeof ResizableBox > = ( { | ||
onResizeStop, | ||
...props | ||
} ) => { | ||
const [ { height, width }, setAttributes ] = useState( { | ||
height: 200, | ||
width: 400, | ||
} ); | ||
|
||
return ( | ||
<ResizableBox | ||
{ ...props } | ||
size={ { | ||
height, | ||
width, | ||
} } | ||
onResizeStop={ ( event, direction, elt, delta ) => { | ||
onResizeStop?.( event, direction, elt, delta ); | ||
setAttributes( { | ||
height: height + delta.height, | ||
width: width + delta.width, | ||
Comment on lines
+50
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
} ); | ||
} } | ||
/> | ||
); | ||
}; | ||
|
||
export const Default = Template.bind( {} ); | ||
Default.args = { | ||
children: ( | ||
<div | ||
style={ { | ||
background: '#eee', | ||
display: 'flex', | ||
height: '100%', | ||
width: '100%', | ||
alignItems: 'center', | ||
justifyContent: 'center', | ||
} } | ||
> | ||
Resize | ||
</div> | ||
), | ||
}; | ||
|
||
/** | ||
* The `enable` prop can be used to disable resizing in specific directions. | ||
*/ | ||
export const DisabledDirections = Template.bind( {} ); | ||
DisabledDirections.args = { | ||
...Default.args, | ||
enable: { | ||
top: false, | ||
right: true, | ||
bottom: true, | ||
left: false, | ||
topRight: false, | ||
bottomRight: true, | ||
bottomLeft: false, | ||
topLeft: false, | ||
}, | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably hide
children
's control, as it currently shows a react object that can't really be editedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True 👍