Scripts: Allow WP_DEVTOOL to set devtool in prod builds #46812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Any update here @gziolo @ntwb @nerrad @ajitbohra @ryanwelcher ? |
Do I understand it correctly that the only difference with #45251 would be that it keeps the default behavior as is, but it allows overriding for both production and development at the same time? It sounds like a nice addition 💯 |
Yes. With this approach in here, you don't change the current default behavior. So we have following scenarios: 1. default: 2. I need SourceMaps: See all available variants here: https://webpack.js.org/configuration/devtool/ |
gziolo
changed the title
gziolo
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
This looks good. It would be nice to include a note in the CHANGELOG, so folks are aware of new behavior for production builds when the flag is explicitly enabled.
It's a backward-compatible version in contrast to the #45251 alternative.
noahtallen
force-pushed
the
try-prod-devtool
branch
from
d24ac54 to
b6b9a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #45251. Allows
WP_DEVTOOLto set the source map mode for production builds as well as dev builds.Why?
Resolves #44278. Currently, wp-scripts can't create sourcemaps for production builds.
How?
Set devtool whether or not we're in dev mode.
Testing Instructions
Mostly, verify the logic. If you have an existing project, verify that you can create sourcemaps with
WP_DEVTOOL.Testing Instructions for Keyboard
Screenshots or screencast