Toolbar: move all subcomponents under the same folder #46951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
ciampo
commented
Jan 6, 2023
Comment on lines
-18
to
+25
| export { default as Toolbar } from './toolbar'; | ||
| export { default as ToolbarButton } from './toolbar-button'; | ||
| export { default as __experimentalToolbarContext } from './toolbar-context'; | ||
| export { default as ToolbarGroup } from './toolbar-group'; | ||
| export { default as ToolbarItem } from './toolbar-item'; | ||
| export { default as ToolbarDropdownMenu } from './toolbar-dropdown-menu'; | ||
| export { | ||
| Toolbar, | ||
| ToolbarButton, | ||
| ToolbarContext as __experimentalToolbarContext, | ||
| ToolbarDropdownMenu, | ||
| ToolbarGroup, | ||
| ToolbarItem, | ||
| } from './toolbar'; |
There was a problem hiding this comment.
@geriux quick ping to make sure that the native side still builds and works like before
ciampo
commented
Jan 6, 2023
Comment on lines
+1
to
+6
| export { default as Toolbar } from './toolbar'; | ||
| export { default as ToolbarButton } from './toolbar-button'; | ||
| export { default as ToolbarContext } from './toolbar-context'; | ||
| export { default as ToolbarDropdownMenu } from './toolbar-dropdown-menu'; | ||
| export { default as ToolbarGroup } from './toolbar-group'; | ||
| export { default as ToolbarItem } from './toolbar-item'; |
There was a problem hiding this comment.
For ease of review: the contents of this file have simply been moved to packages/components/src/toolbar/toolbar/index.js (the only code changes would be in the import paths).
A new index.js file was then added to re-export all components out of the toolbar folder.
Reviewing this PR commit-by-commit may be simpler.
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 4531710. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3874016107
|
mirka
approved these changes
Jan 6, 2023
ciampo
force-pushed
the
components/toolbar-unify-subcomponents
branch
from
edab6d7 to
4531710
Compare
ciampo
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Unify under the same parent
toolbarfolder all related subcomponents.Why?
This PR is in preparation to two refactors:
Moving all of the subcomponents under the same folder will reduce overhead during those two refactors, while keeping all these changes in a separate PR will also greatly reduce diff noise.
How?
Toolbar*subcomponent in its own folder, under thetoolbarfolderstoriesfoldertestsfoldertsconfig.jsonTesting Instructions
trunk