Notice: Remove knobs in stories #46956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 0c58bbd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3859399643
|
ciampo
approved these changes
Jan 9, 2023
Comment on lines
+6
to
+7
| // TODO: Add a story involving NoticeList to help people understand | ||
| // the difference between onDismiss/onRemove. |
There was a problem hiding this comment.
Similar situation to Snackbar and SnackbarList. In those situations, should we treat these components as part of the same family? In that case, which component is the "main" component?
There was a problem hiding this comment.
I think we'd need to evaluate each case based on whether the Foo component can be used independently of the FooList or FooGroup. If it can be used independently, that would be the main component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
What?
Remove the Knobs add-on from
Noticestories.Why?
This is now a blocker for supporting npm 8 (#46443).
How?
Just a quick, minimal refactor.
Testing Instructions
npm run storybook:devNoticecomponent.