Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: set the default width to none #46971

Closed
wants to merge 1 commit into from

Conversation

carolinan
Copy link
Contributor

What?

WIP, testing fixtures/deprecation

Changes the default align of the Media & Text block from wide to none.
Fixes #20941

Why?

Users and developers have reported that the wide alignment is unexpected and that they would prefer it to be set to none by default (see the discussions in the issue)

How?

Updates the default value of the align block attribute in block.json

Testing Instructions

  1. Place a Media & text block in the Site Editor or block editor.
  2. Confirm that the width is the default content width, not wide.

@carolinan carolinan added [Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement. labels Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Flaky tests detected in 08d0964.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3873065815
📝 Reported issues:

@aaronrobertshaw
Copy link
Contributor

@carolinan I had intended that we merge #48404 into this PR given you got the ball rolling but since I wasn't thinking when I pinged others for review on #48404, it might be cleanest to close this one.

If it's an issue, we can re-juggle things but I'll close this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default Wide width alignment for Media & Text block to normal width.
2 participants