Lodash: Remove _.pickBy() from editor hooks
#46982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
tyxla
commented
Jan 9, 2023
| pickBy( | ||
| nextAttributes, | ||
| ( value, key ) => metaAttributes[ key ] | ||
| Object.entries( nextAttributes ?? {} ) |
There was a problem hiding this comment.
nextAttributes could theoretically be nullish, so we're falling back to an empty object just in case.
| @@ -108,7 +107,11 @@ const createWithMetaAttributeSource = ( metaAttributes ) => | |||
| function shimAttributeSource( settings ) { | |||
| /** @type {WPMetaAttributeMapping} */ | |||
| const metaAttributes = mapValues( | |||
| pickBy( settings.attributes, { source: 'meta' } ), | |||
| Object.fromEntries( | |||
| Object.entries( settings.attributes ?? {} ).filter( | |||
There was a problem hiding this comment.
settings.attributes could theoretically be nullish, so we're falling back to an empty object just in case.
|
Size Change: +17 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 38c60a4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3874406863
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.pickBy()from the editor hooks. There are just a couple of usages in that block and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Object.fromEntries( Object.entries() )withArray.prototype.filter()instead of_.pickBy().Testing Instructions
/packages/e2e-tests/pluginsdirectory.meta-attributes-block.phpand themeta-attributes-blockdirectory.my_metameta updates on save.my_metaon save, the content inside the blocks changes.