Fix flaky tests reporter not posting comments on contributors' PR #46988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Continued from #45798 and #46785, I found out that PRs made by contributors won't trigger the comment. This PR tries to solve that.
Why?
It's because we're using the
pull_requestevent, which has no write permissions for contributors.How?
The solution is to use the
workflow_runevent, which has the necessary permissions. Funny enough that this was how it worked before I introduced changes in #45798 😅.I also update the unit tests to include semi-realworld fixtures for the
workflow_runevents to minimize mocking. Most of the line changes are from those fixture files.Testing Instructions
This is hard to test as it not only requires a fork with all the setup mentioned in #45798 (comment), it also has to be tested with a contributor with no write access to the fork. I have not yet been able to test this with the latter, but you can view an example PR in kevin940726#49.