Fix TreeGrid keyboard nav skipping Edit Block button in off canvas editor #46998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vigating via keyboard
talldan
added
[Type] Bug
talldan
requested review from
scruffian,
MaggieCabrera,
getdave,
alexstine,
andrewserong and
draganescu
|
Size Change: -3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jan 10, 2023
15 tasks
|
Thanks for fixing this one up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #46939 (comment) (second item)
What?
In the off-canvas editor, pressing the right arrow key when the block is focused should move focus to the Edit Block button. Instead it skips that and moves focus to the block options menu button.
Why?
I think this came about because List View only has two columns, so the keyboard nav was updated with that in mind, and it didn't cause any issues.
The off-canvas editor generally has three columns, so this problem has become evident.
This fix shouldn't change anything in the main List View, it should just fix the issue in the off-canvas editor.
How?
Fixes the issue by using the already calculated
nextIndexinstead of always focusing the last item in the row (focusableItems.length - 1).Testing Instructions for Keyboard
Note that some blocks have don't have an 'Edit x block' button, specifically the inner blocks of a Page List currently don't.
Screenshots or screencast
Before
Kapture.2023-01-10.at.13.58.48.mp4
After
Kapture.2023-01-10.at.13.56.53.mp4