Restore the browse all button in the site editor #47054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: -9 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 11, 2023
|
Oh right, I'll leave the issue open then :) |
|
Flaky tests detected in c0b65d7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3891993463
|
|
Thanks for bringing it back @youknowriad 🙇🏻 |
|
Looks like it's gone again. Was this intentional? Created an issue: #52526 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #44770 the "browse all" button in the inserter has been inadvertently removed from the site editor because the "inserter" state has been moved to the site editor store but the callback was not being provided any more. This PR fixes that by passing the callback properly.
Testing Instructions
1- open the site editor
2- trigger the in-between inserter
3- the "browse all" button should be visible and working properly.