Prioritize specific blocks (e.g. Gallery) over Shortcode block during conversion #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes a regression affecting freeform->block conversion and pasting of strings such as `[gallery]`.
mcsf
added
[Type] Bug
mcsf
changed the title
ellatrix
approved these changes
Jan 27, 2018
| // yielding non-deterministic results. A proper solution could be to | ||
| // let the editor (or site owners) determine a default block handler of | ||
| // unknown shortcodes — see `setUnknownTypeHandlerName`. | ||
| shortcode, |
There was a problem hiding this comment.
How about moving it out of this array to make things extra clear? registerBlockType( shortcode.name, shortcode.settings );?
There was a problem hiding this comment.
Both work for me :) Hopefully it will be fixed soon as described in the comment.
There was a problem hiding this comment.
Not sure. It feels like all the core blocks should be gathered in a single place, and the current approach of creating an array and looping over it seems more apt. Placing a registerBlockType call for Shortcode beside that loop could perhaps make it less visible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression identified in #4514 (comment) whereby freeform-to-block conversion and pasting of known shortcodes, such as
[gallery]was intercepted by the generic Shortcode block.Description
Read comment in diff for details. The gist is that shortcode conversion doesn't support concurrent shortcode transforms, in that there is no explicit prioritization mechanism to handle conflicting matches. A proper solution is underway, but until then this quick fix restores registration order to its state before #4514.
How Has This Been Tested?
[gallery]or some custom transform-enabled shortcode.[sfoihergv]).Types of changes
Bug fix.
Checklist: