-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notice: refactor to TypeScript #47118
Conversation
68198a5
to
eb5fad8
Compare
Size Change: +5 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Flaky tests detected in 8144310. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4032516688
|
673273d
to
88a314f
Compare
a2e8e86
to
aa3a9a4
Compare
aa3a9a4
to
6a29fb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here 🎉 Thanks for the attention to detail, plus cleaning up the outdated bits in the readme!
6c50397
to
81dbb3b
Compare
9c8815f
to
486a948
Compare
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
This reverts commit 639be12.
8144310
to
d43fe8f
Compare
What?
Refactor
Notice
component to TypeScriptPart of #35744
Why?
The refactor to TypeScript has many benefits (auto-generated docs, static linting and error prevention, better IDE experience). See #35744 for more details
How?
Followed the steps in the TypeScript migration guide
Testing Instructions
Notes
Snackbar
to re-use the newNotice
types, as recommended in Convert theSnackbar
component to TypeScript #45472Followups
OnRemove
andOnDismiss
are confusing props. InNotice
there's really no difference between them. InSnackbar
however there is a subtle difference in behavior, so it would be good to update the docs of that component to make the distinction more clear.