-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a test PR for 46510. Please don't review. #47124
Conversation
Props to @jrfnl for suggesting it.
Props to @jrfnl for finding this bug.
Props to @jrfnl for identifying an issue with PHP 7.4 and 7.4. # Conflicts: # packages/env/CHANGELOG.md
2. Don't put the OS version in the matrix.
…"Set up PHP" step.
2. Move the cache option to the phpcs.xml.dist
…hould be removed as well. Props to @jrfnl.
…ious)." This reverts commit eaef3343f85faa8f50f7465eb70105cac961d0ca.
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Flaky tests detected in 801b407c871ef40661b0af90c16cf546ccff2bf7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3929175375
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
35e3997
to
801b407
Compare
This is needed because: 1. unit-php job has to be preserved as it's set as required in the GH settings. 2. unit-php job now depends on the test-php job.
801b407
to
2a371d8
Compare
This was needed for testing purposes only. |
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast