Adds a global save button to the site editor #47142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
Size Change: +85 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Thanks for the PR. I wanted to connect some dots to #46985 (comment) as I'm not entirely convinced the site hub is the right place for this. What do you think? |
|
Personally I don't like random save buttons (like in the bottom of the sidebar). I understand the reasoning but there's also two ways to look at it, one of them is: The site editor being a single unit to edit your site and save your changes from a unique place when you're done. I'll let you all discuss this and we'll see what to do. |
youknowriad
force-pushed
the
add/global-save-button
branch
from
65de6f9
to
df12c89
Compare
|
I'm repurposing this PR to try a new design: I've moved the save button to the bottom of the sidebar. There's still some work to do here though:
For now, this leaves the hub untouched. |
|
Flaky tests detected in 28ea03b6bd1d00a4df9485b7620f6d8bf49f9d5d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4074318409
|
youknowriad
force-pushed
the
add/global-save-button
branch
from
df12c89
to
28ea03b
Compare
|
Looks good, here's how it works:
I like to think that we can use the save button in-editor most of the time. I.e. you drill into templates, click an edit button next to a template, go into the full editor, save, and go back. But for the higher level actions like sorting the primary navigation, adding pages, in the future: site title/logo changes, style changes, it makes sense to be able to make a lot of those changes, label them into a bundle, save them, and schedule them for example to go out on a day a big sale is going to happen. For that, we do need a global save button that persists across sections, as it can also there serve as a hub for revisions and scheduling. Can we make it so the entire bottom save hub only appears once a change that requires saving has been made? |
|
I've updated the save button to show a modal. The design of the modal itself is not perfect but I think it's a good start. I can't tweak it too much for now without impacting the save panel within edit mode, so we need to be a bit careful there. |
|
I've updated the PR, the save hub is only available when there are changes to be saved. |
youknowriad
force-pushed
the
add/global-save-button
branch
from
73f9cc5
to
ad7c0ba
Compare
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Is this good enough for a v1 of the save button in the site editor? What needs to be improved? |
|
Looks good. I don't know if it has to be a modal or not, the sidebar could also temporarily work as we refine soe of the other bits. |
jasmussen
approved these changes
Feb 2, 2023
Mamaduka
added
the
Backport to Gutenberg RC
|
I think this broke the panel in post editor. |
Mamaduka
removed
Backport to WP 6.7 Beta/RC
|
@ntsekouras I'll take a look. I made sure to test it but for some reason it didn't break for me. |
|
I see the broken panel as well. Screenshot
|
|
If we have to have the panel in the design section, that's okay, it doesn't have to become modal quite yet. |
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 7, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
This was referenced Feb 8, 2023
This was referenced Jul 5, 2023
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #36667 closes #46985
What and why?
This PR tries to add a global save button to the site editor. Check #46985 for the reasoning. The TLDR is that we're able to make edits to the templates and navigation... from within the edit mode but also outside it, meaning there's a need to save changes globally.
How?
Testing Instructions
1- Open the site editor
2- Enter edit mode and make changes to any part of the site
3- Leave the edit mode without saving
4- You should be able to save using the "save" button inside the site editor sidebar.