List View: Fix crash when the first template-parts is deleted width del key #47227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9b8500f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3945545775
|
Mamaduka
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Guarding against null here makes sense to me 👍
It would be nice to track down the actual cause of the issue, but I'm guessing it's related to Redux's "zombie children" or something similar.
Interestingly, the error doesn't happen if the first block is Reusable, which is also a synced block.
andrewserong
approved these changes
Jan 18, 2023
|
@Mamaduka @andrewserong
Yes, this is very odd. However, I think this solution is reasonable for now and would like to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47226
What?
This PR fixes the site editor crash when deleting the first template part block with the
delkey while the list view is open. This problem occurs when the template part block you are trying to delete is at the top of the block list.Why?
I have confirmed that the
useBlockDisplayInformationhook returnsnullwhen the first template part is deleted with the del key.I don't know why this does not occur when deleting from the dropdown, but I expect it is because the order of events and processing changes.
I also believe that the null check is necessary because
useBlockDisplayInformationmay returnnull.How?
Added optional chaining.
Testing Instructions
Before
before.mp4
After
after.mp4