Try: Filter Pattern Categories by Editor Type #47275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.93 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in aa9f190. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3997796164
|
mikachan
added
[Feature] Patterns
mikachan
changed the title
mikachan
changed the title
|
Speaking personally, I do think it makes sense to have a split with the post editor as much of those patterns aren't useful there and it helps to proactively curate things a bit for users. I would move forward with implementing this but I'm curious what @WordPress/gutenberg-design thinks though as this ultimately is a design question mark. |
|
Ok, so the PR is about creating a filter showing all Patterns in the Site Editor and removing those patterns that does not feel natural to show in the Post Editor be filtered out / not seen. This PR will remove the Header and Footer patterns from the Post Editor. It seems like a good idea! It is good to have a filtering mechanism in place to where a developer can filter which pattern categories to show in the Post and/or Site Editor. I will assume it will be developer friendly making it possible for a developer to filter it like they need. |
|
This makes sense to me. I noticed that the site editing categories are still hidden while template editing via the post editor, IE when you click this 'Edit template' button:
It probably makes sense for them to be available in that context, if possible. |
ntsekouras
reviewed
Feb 15, 2023
There was a problem hiding this comment.
I think this API should consider the semantics of patterns and their categories. It might be not as simple as adding a field to the categories.
Maybe it makes more sense to add it to patterns instead and have a block editor setting for allowed pattern categories? 🤔 I'll have it think more about it..
| ( x, index, arr ) => | ||
| index === arr.findIndex( ( y ) => x.name === y.name ) | ||
| ) | ||
| .filter( ( cat ) => { |
There was a problem hiding this comment.
With only a check like that, any pattern that belongs to such categories(ex footers) will still be present in post editor, but under uncategorized.
There was a problem hiding this comment.
Ah right, thanks for highlighting!
This makes sense 👍
I like the idea of having allowed pattern categories. Patterns can already have categories, so would the work for this involve adding the new block editor setting? |
|
@mikachan Is this PR still relevant or can it be closed now? |
|
Going to close as inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds the ability to filter Pattern Categories by editor type (post or site editor), as a small step to improving the pattern inserter experience.
Why?
Part of #44501
How?
Adds an
editorskey to the block patterns category controller, which accepts an array of allowed editors (core/post and/or core/site). Also adds an additional filter toblockPatternCategories, which filters by editor type based on theeditorskey.Currently, the 'Headers' and 'Footers' categories have been restricted to only showing in the Site editor.
This PR also adds a description to the 'Banners' category, as it was previously missing.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast