Do not override rich text role attribute #47276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
added
[Focus] Accessibility (a11y)
|
Size Change: +2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 93317de. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3957213090
|
|
@vcanales Thanks for the PR. How should I test this? Which blocks should we use to determine a pass or fail? So far, I am not noticing anything broken but would like exact testing steps. Thanks. |
|
@vcanales thanks for your PR. I'm not sure it would fully solve the issue though. In #42158 I tried to explain this is a two-fold issue: wrong role passed by To quickly recap:
Basically, the presence of the wrapper element and the usage of To be fair, the current situation is very far from ideal. I'm not necessarily against this change, as it makes sure an editable 'field' is always exposed to assistive technologies as a @alexstine I think this should be tested with JAWS, as the I'd greatly appreciate some help to revive the discussion on #42158 so that it can get some higher priority! |
|
Closing in favor of other efforts. I am thinking about how to modify |
|
@alexstine I would appreciate a link to the PR that has taken precedence over this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make sure the role of the Rich Text component is always set to
textboxand avoid setting it todocumenton certain blocks, listed here.Why?
Allowing for the possibility of the role of the Rich Text component to be anything other than
textboxopens up the possibility for an inconsistent experience for folks using Assistive Technologies.Thoughts that motivate this:
aria-multiline=trueelement be anything other thanrole="textbox".textbox; especially notdocumentwhich is defined as