Sticky Position: Hide controls if the block is non-root (has parents) #47334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
|
Size Change: +36 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
andrewserong
requested review from
apeatling,
jameskoster,
richtabor and
tellthemachines
richtabor
approved these changes
Jan 23, 2023
jameskoster
approved these changes
Jan 23, 2023
andrewserong
deleted the
try/hide-sticky-position-controls-if-the-block-has-parents
branch
13 tasks
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #47043
Hide the sticky position controls if the selected block is not at the root-level within the document.
Why?
This PR explores an idea from #47230 (comment) — to reduce the complexity of dealing with sticky positioning and avoid the UX problem of applying sticky to a non-root-level block (and the user being confused as to how it works), let's hide the sticky controls for non-root blocks for now.
How?
stickyto the list of available optionsdefault)InspectorControlscomponent down a level so that we only render this if there is more than one option available (this is a tiny optimisation to ensure that we only ever do the block parents lookup for blocks that use the position controls)Testing Instructions
Note: the logic will still display the Position controls if a value has been set, and the block is at a non-root level — this is to support backwards compat since the position feature has already landed in Gutenberg, and also enables the user to switch off the position if a block is moved to a non-root level of the document.
Screenshots or screencast