Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove right navigation sidebar from edit-site. #47354

Conversation

jorgefilipecosta
Copy link
Member

Follow up to #46436.

Removes the right navigation sidebar as now we have that sidebar on browse mode.

@jorgefilipecosta jorgefilipecosta added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 23, 2023
@jasmussen
Copy link
Contributor

Thank you! I guess this mainly needs a technical look.

@youknowriad
Copy link
Contributor

I guess since the navigation in the site editor sidebar on the left is behind a feature flag, we should still keep the other one if the feature flag is disabled?

@youknowriad
Copy link
Contributor

Do you know when the feature flag is supposed to be removed?

@jasmussen
Copy link
Contributor

Was about to ask if the feature flag can instead hide the navigation in the site editor. But I guess the question then becomes: do we actually need that feature flag anymore? It doesn't seem like it. CC: @getdave as I think you may have worked on the inspector interface.

@jasmussen
Copy link
Contributor

We need to figure out the save button challenge before we remove the one on the right:

nav

I think we can probably have a good idea for how to do that very soon, as we're working on mockups for it.

@getdave
Copy link
Contributor

getdave commented Jan 25, 2023

The experiment was only there as the feature was still experimental. It looks like Jorge is shepherding this out of experimental which seems ok to me.

My understanding is that this is not using the same code as the Nav block "offcanvas" list view which is good as that feature is still experimental at this time.

@youknowriad
Copy link
Contributor

I think we can probably close this PR right now as the flag has been removed separately.

@youknowriad youknowriad closed this Feb 2, 2023
@youknowriad youknowriad deleted the feature/remove-right-navigation-sidebar-edit-site branch February 2, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants