GlobalStyles hooks: do not smart merge presets in useGlobalSetting #47415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
Size Change: -25 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2fd03c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4004627287
|
jorgefilipecosta
approved these changes
Jan 25, 2023
| @@ -46,10 +43,10 @@ function ScreenBackgroundColor( { name, variationPath = '' } ) { | |||
| const hasBackgroundColor = | |||
| supports.includes( 'backgroundColor' ) && | |||
| isBackgroundEnabled && | |||
| ( solids.length > 0 || areCustomSolidsEnabled ); | |||
| ( colorsPerOrigin.length > 0 || areCustomSolidsEnabled ); | |||
There was a problem hiding this comment.
Nice change the useColorsPerOrigin hook already includes only not empty origins so we can just rely on it 👍 .
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #47356
What?
This PR removes the automatic computation of the presets from useGlobalSetting hook.
Why?
There are several reasons for this change:
How?
Note: There's another "smart" behavior that I'd like to remove from
useGlobalStylethis time which is the automatic "decoding" of the styles (from CSS vars or the preset format to actual values). The reasoning is similar, consumers and producers of global styles should be able to know the original value and act accordingly. That one is going to be done by steps though as it's more impactful.Testing Instructions
1- Open the global styles panel and try to use and edit presets (colors, gradients, fontSizes, fontFamilies)