Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constrained tabbing failures with Safari and Firefox #47426

Merged
merged 11 commits into from
Feb 14, 2023
Merged

Fix constrained tabbing failures with Safari and Firefox #47426

merged 11 commits into from
Feb 14, 2023

Commits on Feb 9, 2023

  1. Make the modal content container focusable when scrollable.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7c087b4 View commit details
    Browse the repository at this point in the history

  2. Add test, improve existing a11y tests and run them with all browsers.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    80ea82d View commit details
    Browse the repository at this point in the history

  3. Fix useConstrainedTabbing edge cases.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7a87f07 View commit details
    Browse the repository at this point in the history

  4. Add basic focus style for the scrollable section.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    66a4693 View commit details
    Browse the repository at this point in the history

  5. Update snapshots.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2ce7d2a View commit details
    Browse the repository at this point in the history

  6. Clean up a11y test.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4fcb5b7 View commit details
    Browse the repository at this point in the history

  7. Refine test.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3900724 View commit details
    Browse the repository at this point in the history

  8. Remove scrollableContentLabel prop.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    abc31c2 View commit details
    Browse the repository at this point in the history

  9. Restore conditional aria-label for the scrollable section.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    04b9c37 View commit details
    Browse the repository at this point in the history

  10. Update test after change to closeButtonLabel default.

    @afercia
    afercia committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    47a5430 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Add comment to clarify test.

    @afercia
    afercia committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    50da893 View commit details
    Browse the repository at this point in the history