Reset default_comment_status to previous value after post comments form e2e test #47481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
talldan
deleted the
update/post-comments-form-test-to-reset-comment-status
branch
juanmaguitar
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In passing, I noticed the post comments form e2e test doesn't clean up after itself. It sets the
default_comment_statusoption toclosed, but doesn't return it to the previous value.This PR updates the test to reset the value of the option.
Why?
Tests that don't tidy up after themselves can lead to hard to debug test failures.
How?
The
setOptionutil returns the previous value of the option, so that can be used to reset the value.Testing Instructions
Tests should still pass.