-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TreeGrid: Convert to TypeScript #47516
Merged
Merged
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
33b564c
TreeGridRow: Convert to TypeScript
mirka 3ff85fa
Add types for roving tab index
mirka 8d8788b
Actually throw if context is undefined
mirka 78b5a68
TreeGridItem: Add types
mirka 1f4cc0b
TreeGridCell: Add types
mirka 946d6c7
TreeGrid: Add types
mirka 48533dd
Fixup
mirka d858faf
Convert stories
mirka 3458a05
Convert tests
mirka 9353567
Exclude from tsconfig
mirka 34a29ff
Improve prop description for `withoutGridItem`
mirka 52cbdd9
Simply focusable element type
mirka 8ae06f9
Remove unnecessary eslint-disable
mirka 37031c5
Tweak aria types
mirka 12e9145
Update readme
mirka 9d2523f
Add changelog
mirka cd66379
Change confusing story
mirka bfc4943
Merge branch 'trunk' into ts-treegrid
mirka d30ea0b
Shift all possible `Element`s to `HTMLElement`
mirka 2497ee6
Merge branch 'trunk' into ts-treegrid
mirka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { forwardRef } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import TreeGridItem from './item'; | ||
import type { WordPressComponentProps } from '../ui/context'; | ||
import type { TreeGridCellProps } from './types'; | ||
|
||
function UnforwardedTreeGridCell( | ||
{ | ||
children, | ||
withoutGridItem = false, | ||
...props | ||
}: WordPressComponentProps< TreeGridCellProps, 'td', false >, | ||
ref: React.ForwardedRef< any > | ||
) { | ||
return ( | ||
<td { ...props } role="gridcell"> | ||
{ withoutGridItem ? ( | ||
<>{ children }</> | ||
) : ( | ||
<TreeGridItem ref={ ref }>{ children }</TreeGridItem> | ||
) } | ||
</td> | ||
); | ||
} | ||
|
||
/** | ||
* `TreeGridCell` is used to create a tree hierarchy. | ||
* It is not a visually styled component, but instead helps with adding | ||
* keyboard navigation and roving tab index behaviors to tree grid structures. | ||
* | ||
* @see {@link https://www.w3.org/TR/wai-aria-practices/examples/treegrid/treegrid-1.html} | ||
*/ | ||
export const TreeGridCell = forwardRef( UnforwardedTreeGridCell ); | ||
|
||
export default TreeGridCell; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified this code snippet a bit to cut down on the number of lines.