Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter to allow social services edits #47529

Closed
wants to merge 1 commit into from
Closed

Add a filter to allow social services edits #47529

wants to merge 1 commit into from

Conversation

imath
Copy link
Contributor

@imath imath commented Jan 29, 2023

What?

This PR introduces the block_core_social_link_services filter so that it's possible to add a new social links to the corresponding block.

Why?

  • There will always be new social services the block_core_social_link_services() function might not include.
  • Used inside a corporate Intranet, it would be the only way to include corporate social inks.
  • It can also be used to restrict/disable unwanted social links by administrators.

How?

This PR introduces the block_core_social_link_services filter inside the block_core_social_link_services() function.

@imath imath requested a review from ajitbohra as a code owner January 29, 2023 04:59
@talldan
Copy link
Contributor

talldan commented Jan 30, 2023

Thanks for the contribution.

I remember some discussion on this before, and there's an issue that the services and associated icons are specified in two separate places—in the JS code for the block and in the PHP code (which this PR touches).

I think filters would need to exist for both, though for the frontend code users can already specify variations, which could mean a filter isn't needed.

It'd be good to see some docs for this so that devs know how to implement the full experience.

@talldan talldan added [Feature] Extensibility The ability to extend blocks or the editing experience [Block] Social Affects the Social Block - used to display Social Media accounts labels Jan 30, 2023
@github-actions github-actions bot added the Stale label Jul 30, 2023
@gziolo gziolo added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Feature] Extensibility, [Status] Stale, [Block] Social.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@gziolo gziolo removed the Stale label Sep 9, 2024
@imath imath closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Extensibility The ability to extend blocks or the editing experience [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants