Try: Zero out excerpt paragraph margins. #47538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -351 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Editor: I think the collapsing between the paragraph and the read more is OK. Front: What does look strange is, for example In Twenty Twenty-Three, that there is no space between the post excerpt and the block below it. |
|
Would it be safer to start by adding back some margin? |
|
Flaky tests detected in 83096ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4042710064
|
|
But if the margin is moved from the |
|
Moving it to the div makes sense. Let me try in a minute. |
|
Pushed a fix, I think that works well:
|
|
This still looks strange to me: And while we could fix it in Twenty Twenty-Three, it would be an unexpected change for users of other themes that we have no control over. |
|
Hmm. Maybe we should keep the bottom margin, and not touch the Read More button for now? |
|
@jasmussen Thank you for working on this with such short notice. I think we want |
|
Thanks @iamtakashi. That gets us to here:
Is this what we want? Wouldn't that make your original doodle impossible? |
|
In that way, the margins added will collapse or will be removed when the excerpt block is the first or the last block in a container just like other blocks. I think I’ve tested that when I wrote the comment, but I can make sure when I back to my desk. |
|
I committed your change, you should be able to test it in the branch now, or on http://gutenberg.run/47538 |
|
Thanks for the change, @jasmussen. It works very well. The margins are present when we need them and are not there when we don't need them.
|
|
Cool, let's see if we can get this merged. @carolinan are you able to take another look? |
carolinan
approved these changes
Feb 1, 2023
|
Thank you. I'll merge and will be happy to follow up. |
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
|
Nice! Ran into this the other day as well. Good stuff. |
Mamaduka
added
the
Backport to Gutenberg RC
Mamaduka
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Try: Zero out excerpt paragraph margins. * Address feedback. * Commit change.
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 404ba23 |
Mamaduka
removed
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #47457.
This PR attempts to zero out the paragraph margins on the post excerpt block. Before, showing the default browser-style inherited margins:
After, no margins:
Why?
Two main reasons: firstly, at the moment, the excerpt paragraph is essentially unstyled. By inheriting from the browser stylesheet, there's no connection to the rest of the site.
Note how paragraphs in the rest of the site have a more gap behavior:
There's a collapsing happening when the Read More block is filled in:
I'd like your feedback on that one. I think it looks good, but if we want to be safe, we can add some top margin to the read more block and fix this.
Testing Instructions
Test the excerpt block in the site editor.