Refactor Default Colors and the ColorPalette component #4755
Conversation
editor/components/provider/index.js
Outdated
| @@ -32,6 +32,20 @@ import store from '../../store'; | |||
| */ | |||
| const DEFAULT_SETTINGS = { | |||
| alignWide: false, | |||
| blockTypes: true, | |||
There was a problem hiding this comment.
Same here, this ensures all blocks are available by default.
There was a problem hiding this comment.
See #4707. Includes a comment in that PR.
There was a problem hiding this comment.
I just merged, so let's drop the change here.
editor/components/provider/index.js
Outdated
| @@ -32,6 +32,20 @@ import store from '../../store'; | |||
| */ | |||
| const DEFAULT_SETTINGS = { | |||
| alignWide: false, | |||
| blockTypes: true, | |||
There was a problem hiding this comment.
I just merged, so let's drop the change here.
youknowriad
force-pushed
the
refactor/colors
branch
from
79807b9
to
11fd3c3
Compare
youknowriad
dismissed
aduth’s stale review
Rebased and removed the duplicate key. Thanks
youknowriad
force-pushed
the
refactor/colors
branch
from
11fd3c3
to
a2a8e95
Compare
How will we plan to allow plugins to filter this? Or would this need to occur in the client? |
|
@aduth Why would we allow plugins to filter this? I mean we can still allow a filter on the frontend but we already have a theme support config to override these colors. |
|
The override is a full replacement though, yeah? Maybe not a common use case, but doesn't seem simple as-is for a theme to add a new value. |
Tiny PR that does two things related to colors:
Moves the default colors to the frontend making the Editor script more reusable without the need of the server-side bootstraping.
Small fix the ColorPalette component to accommodate the empty colors use-case. (Avoid JS errors)
Testing instructions