Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Bump Aztec-Android version to 1.6.3 #47610

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 31, 2023

What?

Bump Aztec library version to the latest version (1.6.3).

Why?

This PR is a follow-up of #47604 in order to update Android minSdkVersion to 24. The minSdkVersion parameter was updated in Aztec version 1.6.3, therefore to have this parameter with the same value across the Android libraries, we need to bump the Aztec version.

How?

Update Aztec version to version 1.6.3 in the react-native-aztec package.

Testing Instructions

Aztec is used to render the RichText component, so we'd need to test that no regressions have been introduced in blocks that use that component:

  • Paragraph block
  • Heading block
  • Search block
  • Pullquote block
  • File block
  • Button block
  • Shortcode block
  • Contact Info block
  • Gallery block (caption element)
  • Audio block (caption element)
  • Video block (caption element)
  • Embed block (caption element)

Regarding the new changes in Aztec 1.6.3, seems none of them that should impact the RichText component, so it's not needed to test a specific functionality apart from smoke testing the components listed above.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

@fluiddot fluiddot added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 31, 2023
@fluiddot fluiddot self-assigned this Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Flaky tests detected in 13d698b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4066968964
📝 Reported issues:

@fluiddot fluiddot force-pushed the rnmobile/bump-aztec-version-1.6.3 branch from 77b2b4c to ed53b37 Compare February 1, 2023 12:48
@fluiddot fluiddot marked this pull request as ready for review February 1, 2023 13:08
@fluiddot fluiddot requested a review from jhnstn February 1, 2023 15:12
Copy link
Contributor

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the test plan in wordpress-mobile/WordPress-Android#17852 on the WordPress Android build in that PR.

Everything worked as expected :shipit:

# Conflicts:
#	packages/react-native-editor/CHANGELOG.md
@fluiddot fluiddot merged commit 88335db into trunk Feb 1, 2023
@fluiddot fluiddot deleted the rnmobile/bump-aztec-version-1.6.3 branch February 1, 2023 18:09
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 1, 2023
@fluiddot fluiddot changed the title [RNMobile] Bump Aztec version to 1.6.3 [RNMobile] Bump Aztec-Android version to 1.6.3 Feb 1, 2023
@fluiddot
Copy link
Contributor Author

fluiddot commented Feb 1, 2023

Heads up that I've updated the title to specify that the bump is for Aztec-Android, not Aztec in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants