-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shard playwright tests into two separate jobs using a matrix #47629
Conversation
It doesn't seem to have worked. Playwright 1:
Playwright 2:
edit: kudos to @kevin940726 for spotting a stray |
That seems to be working now. Playwright tests took 19 minutes in that last test run, and puppeteer tests 17 minutes. We can consider removing a puppeteer machine and adding another playwright one as more tests are migrated. |
Flaky tests detected in 331f068. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4062162471
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Not sure how many total parts we should use here, but we can always change that in the future.
Looks like we need to change the settings again to mark |
Ah gosh. Lets do it tomorrow, probably not a great thing to do on the plugin release day, especially the last one before 6.2 😄 |
What/Why?
I noticed that Playwright tests are taking around 30 minutes on CI, while each of the Puppeteer tests are taking around 15 minutes. It'd be good to keep them consistent.
This PR tries sharding the playwright tests in a similar way to how we divide up puppeteer jobs. Playwright supports this, so it should be a bit easier.
Hopefully the command I've added will work.
How?
Use a matrix in the github action, to divide tests across two separate machines.