Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code and tests for theme json class after the back port in core #47668

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

tellthemachines
Copy link
Contributor

What?

Applies the improvements from the style variations backport PR back into Gutenberg.

Why?

It make things better.

How?

Testing Instructions

Make sure the changes from #47134 still work;
Run PHP unit tests and make sure they pass.

Testing Instructions for Keyboard

Screenshots or screencast

@tellthemachines tellthemachines added [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality labels Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Flaky tests detected in e39e451.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4071174543
📝 Reported issues:

@ntsekouras ntsekouras added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Feb 2, 2023
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntsekouras ntsekouras changed the title Code improvements and tests for theme json class Update code and tests for theme json class after the back port in core Feb 2, 2023
@ntsekouras ntsekouras merged commit 0fbd15a into trunk Feb 2, 2023
@ntsekouras ntsekouras deleted the add/code-improve branch February 2, 2023 07:17
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants