-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text: stabilise onFocus #47685
Merged
Merged
Rich text: stabilise onFocus #47685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -13 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Flaky tests detected in 81d2bbe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4074588878
|
DaisyOlsen
added
[Type] Bug
An existing feature does not function as intended
[Feature] Rich Text
Related to the Rich Text component that allows developers to render a contenteditable
[Package] Rich text
/packages/rich-text
and removed
[Feature] Rich Text
Related to the Rich Text component that allows developers to render a contenteditable
labels
Feb 14, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Rich text
/packages/rich-text
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #32415.
Not sure why this unstable props is still around. It prevents the proper
onFocus
prop from spreading. Let's "stabilise" it now by removing it so spreading works.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast