Components: Remove unnecessary act()
from Button
tests
#47687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR cleans up a few unnecessary
act()
calls and improves some of theButton
tests.Why?
When preparing our tests to work with React 18 we did a bunch of those
act()
calls. It's time to clean them up where possible.How?
user.tab()
instead of imperative element focus. Directly focusing an element is not something a user can do; they'd rather focus an element through clicking or tabbing. By usinguser.tab()
we alter the tests to better resemble user behavior.await act( () => Promise.resolve() );
calls - they no longer seem to be necessary.Testing Instructions
Verify tests still pass:
npm run test:unit packages/components/src/button/test/index.tsx
Testing Instructions for Keyboard
None
Screenshots or screencast
None