-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Patterns: Add 8 new patterns to query loop block #47710
Conversation
We'll also be adding @richtabor's patterns in this PR #44140 (comment) |
Flaky tests detected in 15b62bb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4077526488
|
We should be able to load these in from the WordPress Pattern Directory, instead of hard-coding them in — yea? Like we did for the bundled header/footer patterns. What do you think? |
Oh nice, I wasn't aware of that. That makes sense. So all we need to do is tag them as |
Yes.
Besides the above, we should also add the |
@ryelle I saw you tagged patterns before to be included, are you able to help with the ones included here (plus these three)? |
Yes, @richtabor will add them to the pattern directory and I'll follow up to add the correct meta values & get them published. |
Closing this one out, thanks everyone! |
Yup! We can close this. |
Fixes #44140
Replaces #44163
What?
Include eight new query block patterns, including some more text based ones.
Why?
See #44140 and #44163 for the reasoning and backstory.
How?
Adds and registers the new query patterns in the 6.2 compatibility file.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast