Global styles: Add check for edit CSS capability to overflow menu #47714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +84 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Thanks for addressing this one @glendaviesnz 👍
It tests as advertised for me.
✅ Permissions check matches the one for the panel card
✅ Custom CSS feature works as expected for a normal site admin
✅ Testing as a site admin on a multisite, the Additional CSS option is not present in the panel or the menu
LGTM 🚢
Mamaduka
added
the
Backport to Gutenberg RC
Mamaduka
pushed a commit
that referenced
this pull request
Feb 3, 2023
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 48dc739 |
Mamaduka
removed
Backport to Gutenberg RC
bph
added
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a check for
edit-csspermissions to the Custom CSS overflow menuWhy?
The Custom CSS feature requires
edit-csspermissions. This is checked for in the display of the Custom CSS global styles panel, but was not copied over when the initial load of this was moved to the sub menu.For context:
unfiltered_htmlcapabilities.edit_csscapabilities and the experiment flag was removed #46815 & #47062.How?
Uses the same permissions check as the panel card
Testing Instructions
define( 'WP_ALLOW_MULTISITE', true );and add a new site (using a subfolder is easiest option) and a site admin for that siteAdditional CSSmenu option is not availableScreenshots
Normal site admin:
Multi site admin: