Navigation: e2e tests: default to my only existing menu #47744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 2578dfa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4125536262
|
MaggieCabrera
changed the title
MaggieCabrera
requested review from
scruffian,
talldan,
getdave,
ajlende and
draganescu
MaggieCabrera
added
[Type] Automated Testing
kevin940726
reviewed
Feb 4, 2023
MaggieCabrera
force-pushed
the
e2e-default-only-menu
branch
from
4f75756
to
d49a247
Compare
|
Ok this should be ready for another review, and hope the tests pass. |
kevin940726
reviewed
Feb 8, 2023
kevin940726
approved these changes
Feb 8, 2023
Co-authored-by: Kai Hao <kevin830726@gmail.com>
MaggieCabrera
force-pushed
the
e2e-default-only-menu
branch
from
c39ac92
to
6e73320
Compare
Thank you so much for your help with this @kevin940726 !! I learned a lot from your review. |
DaisyOlsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is part of the effort to re work all the navigation block e2e tests and migration to playwright. This is one of the user stories described in #45199
This test checks that when only one navigation menu exists, inserting a Navigation block will default correctly to using said menu.
Testing Instructions
Run npm run test:e2e:playwright -- editor/blocks/navigation.spec.js