Navigation Block inspector: fix link UI popover opening on links that have a url #47828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Type] Bug
MaggieCabrera
requested review from
getdave,
scruffian,
ajlende and
draganescu
MaggieCabrera
changed the title
|
Size Change: +1 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
MaggieCabrera
force-pushed
the
link-ui-popover-bug
branch
from
6fd4281
to
8e46fa8
Compare
draganescu
approved these changes
Feb 7, 2023
|
@fluiddot seems like I'm having the same issue that @draganescu had on his PR with the react native e2e tests, do you think this is related to my change at all? I can't get them to pass. Thank you! |
Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com>
MaggieCabrera
force-pushed
the
link-ui-popover-bug
branch
from
8e46fa8
to
9c11ed3
Compare
@MaggieCabrera thanks for the call out 🙇. Similar to my comment on that PR, this change seems unrelated to the mobile E2E test failure, so if it keeps failing, feel free to merge the PR as is. We have recently merged a PR that should improve the stability of the mobile E2E tests, so you could also consider rebasing from |
Thanks for the heads up! |
|
Flaky tests detected in 9c11ed3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4116414120
|
|
Related bug #47829 |
getdave
added a commit
that referenced
this pull request
Mar 2, 2023
Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com>
|
I believe this should have been backported to 6.2. I raised a PR #48676 |
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com>
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 39e4b61 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes a bug when you have a navigation menu with a custom link and you try to insert the navigation block and that triggers the link UI popover on every insert.
Why?
It's a bad bug :D
How?
We are checking for the URL instead of the id of the last inserted block before deciding to trigger the link UI popover open.
Testing Instructions
To reproduce the original bug:
On a clean install, create and save a navigation menu with a custom link.
On a new post, insert a navigation block, you will see the the popover showing even if the link in the menu has a URL.
After the fix, the popover shouldn't show.
If you click on the inserter to add a new custom link to the menu, it should trigger the popover for you to customize the new link.
Screenshots or screencast
The bug:
