Site Editor: Append template type and name to the site editor page title #47855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +594 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9426e5e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4128613144
|
kevin940726
approved these changes
Feb 8, 2023
Comment on lines
141
to
148
| let titleBreadcrumb; | ||
| if ( isReady && editedPost ) { | ||
| const type = | ||
| editedPostType === 'wp_template' | ||
| ? __( 'Template' ) | ||
| : __( 'Template Part' ); | ||
| titleBreadcrumb = `${ editedPost.title?.rendered } ‹ ${ type } ‹ `; | ||
| } |
There was a problem hiding this comment.
Nit: I think can just construct the title string here for simplicity (useMemo is probably not needed):
Suggested change
| let titleBreadcrumb; | |
| if ( isReady && editedPost ) { | |
| const type = | |
| editedPostType === 'wp_template' | |
| ? __( 'Template' ) | |
| : __( 'Template Part' ); | |
| titleBreadcrumb = `${ editedPost.title?.rendered } ‹ ${ type } ‹ `; | |
| } | |
| const title = useMemo( () => { | |
| const type = | |
| editedPostType === 'wp_template' | |
| ? __( 'Template' ) | |
| : __( 'Template Part' ); | |
| return `${ editedPost.title?.rendered } ‹ ${ type } ‹ ${ __( 'Editor (beta)' ) }` | |
| }, [ editedPost.title, editedPostType ] ); |
Then later we can just do:
useTitle( isReady && title );There was a problem hiding this comment.
I was thinking that there might be instances where editedPost was not set so title would then just need to be Editor (beta) but I did some more testing and this doesn't seem to ever be the case, so have simplified as you suggested, but without the useMemo - this isn't a calculation heavy bit of logic so I agree that this probably isn't needed.
apeatling
approved these changes
Feb 9, 2023
glendaviesnz
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
|
Nice! Thanks everyone ❤️ |
youknowriad
reviewed
Feb 13, 2023
| ? __( 'Template' ) | ||
| : __( 'Template Part' ); | ||
| title = `${ editedPost.title?.rendered } ‹ ${ type } ‹ ${ __( | ||
| 'Editor (beta)' |
There was a problem hiding this comment.
I think we should remove "beta" now.
There was a problem hiding this comment.
Also, I'm not entirely certain that we should concat translated items like that, we should probably be using sprintf here.
There was a problem hiding this comment.
There's also a hook useEditedEntityRecord that would save a few lines of code here (allows to call getTitle directly and also provide access to the record if needed.
There was a problem hiding this comment.
I have added a follow up PR here to cover off these suggestions.
youknowriad
added
Backport to WP 6.7 Beta/RC
This was referenced Jul 10, 2023
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the template name and type to the page title
Why?
Currently every page in the editor has the same tile, which makes navigating the history impossible.
Fixes: #47730
How?
Passes the page template name and type into the
useTitlehook.Testing Instructions
Open the site editor
Navigate to different templates and template parts
Check that the page title updates with the template type and name as you navigate, and that the browser history shows the full page titles
Screenshots or screencast
Before:
pagetitle-before.mp4
After:
page-title-after.mp4