-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint: Fix a bunch of ESLint alignment warnings #47872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 🚢
Flaky tests detected in 0143df3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4123815515
|
I wanted to echo my comment #47811 (review) from yesterday:
It would be in another PR for those rules covering stylistic violations😄 |
I'm happy to try that out 👍 |
Suggested in #47878. |
What?
This PR fixes a bunch of ESLint warnings, as well as a couple of TS errors that were unveiled with those fixes.
Why?
Ideally, we shouldn't have any ESLint warnings/errors. This fixes 151 of the total 167 existing ones.
How?
We ran
npm run lint:js:fix
and did a couple of TS massaging changes. BasicallyEntityRecordKey
is anumber | string
, which required the additional TS changes.Testing Instructions
jest/expect-expect
orjest/no-disabled-tests
warnings when runningnpm run lint:js
.Testing Instructions for Keyboard
None
Screenshots or screencast
None