-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: database credentials to wp-env docs #47940
Conversation
I was trying to access the database created by wp-env inside docker using TablePlus and I couldn't find the credentials. I needed to search inside the package to find the default ones being set. https://github.com/WordPress/gutenberg/blob/d5915916abc45e6682f4bdb70888aa41e98aa395/packages/env/lib/config/db-env.js#L3 // Username and password used in all databases. const credentials = { WORDPRESS_DB_USER: 'root', WORDPRESS_DB_PASSWORD: 'password', };
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @creative-andrew! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@creative-andrew Maybe we should link here?
The DB port does change according to the docs.
I agree. We could include a link to https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/getting-started-with-code-contribution.md#accessing-the-mysql-database What do you think about: The database credentials are: user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed about this, and also adding a link to the section about how to access the database
Thanks! |
I was trying to access the database created by
wp-env
inside docker using phpMyAdmin and I couldn't find the credentials. I needed to search inside the package to find the default ones being set.(
gutenberg/packages/env/lib/config/db-env.js
Line 3 in d591591