Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page List: block improvement. #47981

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Page List: block improvement. #47981

merged 1 commit into from
Feb 13, 2023

Conversation

spacedmonkey
Copy link
Member

What?

Micro improvement to the page link block.

Move option lookup outside the foreach loop, resulting in less calls to get_options and an improvement in performance.

Before

Screenshot from 2023-02-10 19-37-20

After

Screenshot from 2023-02-10 19-37-11

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@spacedmonkey spacedmonkey self-assigned this Feb 10, 2023
@github-actions
Copy link

Flaky tests detected in 9f50148.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4147135526
📝 Reported issues:

@carolinan carolinan added the [Block] Page List Affects the Page List Block label Feb 13, 2023
@carolinan carolinan changed the title Page link block improvement. Page list block improvement. Feb 13, 2023
@carolinan carolinan added the [Type] Performance Related to performance efforts label Feb 13, 2023
@spacedmonkey spacedmonkey merged commit 96d601b into trunk Feb 13, 2023
@spacedmonkey spacedmonkey deleted the fix/front-page-lookup branch February 13, 2023 10:40
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 13, 2023
@spacedmonkey spacedmonkey added Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 13, 2023
@DaisyOlsen DaisyOlsen changed the title Page list block improvement. Page List: block improvement. Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Package] Block library /packages/block-library label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@draganescu draganescu Awaiting requested review from draganescu

@georgeh georgeh Awaiting requested review from georgeh

@adamziel adamziel Awaiting requested review from adamziel

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@oandregal oandregal Awaiting requested review from oandregal

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Page List Affects the Page List Block [Package] Block library /packages/block-library [Type] Performance Related to performance efforts
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @carolinan @DaisyOlsen