[Mobile] - Update E2E tests organization and helpers #48026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 07a792b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4183474973
|
fluiddot
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Awesome work @geriux 🏅 , LGTM 🎊 !
I checked the E2E test results on wordpress-mobile/gutenberg-mobile#5462 and confirmed they succeeded. I added some minor comments in the PR but none of them should block the PR.
packages/react-native-editor/__device-tests__/pages/editor-page.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/pages/editor-page.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-types-list/index.native.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-media-blocks-@canary.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-media-blocks-@canary.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-media-blocks-@canary.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-media-blocks-@canary.test.js
Outdated
Show resolved
Hide resolved
added 4 commits
February 14, 2023 16:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR updates some of the current E2E tests we have by merging them into one file, it also updates some of them to use accessibility IDs instead of XPaths.
Why?
After working on wordpress-mobile/gutenberg-mobile#5462 to only make the builds once and reuse them to run E2E test in different jobs e.g. Canary/Full test, it was clear that for iOS it was still taking a bit of time compared to Android.
By investigating I realized that each test takes up to 1 minute and 30 seconds to load the MacOS VM and the simulator, without taking into account the amount of time each test takes. By merging some tests into one file we save up that time and it also makes sense for a few tests to be together.
This is also a pre-work for upcoming visual regression tests where we should use the same approach and have different tests in one file.
I also checked some of the tests and how they were finding elements and a lot of them use XPaths which is not recommended as it is slower compared to using accessibility IDs.
It also removes some workarounds like this one which was already addressed and we can safely remove it.
How?
By merging a few tests together:
gutenberg-editor-audio.test,gutenberg-editor-cover.test,gutenberg-editor-file-@canary.test, andgutenberg-editor-image-@canary.testare now ingutenberg-editor-media-blocks-@canary.testgutenberg-editor-slash-inserter-@canary.testwas moved into:gutenberg-editor-block-insertion-@canary.test.gutenberg-editor-paste.test, andgutenberg-editor-rotation.testare nowgutenberg-editor-device-actions.testUpdates different helpers:
getTitleElement,addNewBlockto use accessibility IDs instead of XPaths.openBlockSettingsto use accessibility IDs instead of XPaths and also to usewaitForElementByAccessibilityIdand theisDisplayedasserter.removeBlockwhich is different fromremoveBlockAtPosition, it removes the selected block.waitForInserterto wait for the Inserter modal to be displayed.assertSlashInserterPresentnow uses accessibility IDs, we had issues with this as it would take a few tries to find the element before.Testing Instructions
CI Checks should pass on both PRs
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A