Editor: Add ifPostTypeSupports higher-order component (try conditional render HoC pattern) #4815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to implement a new
ifPostTypeSupports
higher-order component which serves in place of the existingPostTypeSupportCheck
and attempts to explore a new generalized pattern for conditional component rendering.Example Before:
Example After:
Implementation notes:
The thinking behind the naming convention is that we could create higher-order component-libraries with the following expectations:
ifSomeCondition
withSomeProps
Testing instructions:
Verify that there are no regressions in the behavior of post-type-conditional elements:
comments
ortrackbacks
supports)thumbnail
support)excerpt
support)post-formats
support)author
support)page-attributes
support)revisions
support)