withSpokenMessages: Change js files to typescript #48163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bhavz-10! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
mirka
changed the title
ciampo
added
[Type] Code Quality
|
Hey @bhavz-10 , do you still have capacity to work on this PR? Otherwise we're happy to take over and merge the PR for you 🚀 |
|
Hello @ciampo I will work and push the change requested today. Thank You |
Signed-off-by: bhavz-10 <bhavik.kalpesh@rtcamp.com>
mirka
approved these changes
Mar 6, 2023
|
Hello @mirka Thank you for making the tweak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Converting Javascript files to Typescript
Why?
As mentioned in #35744, we want all javascript files to be converted to typescript
How?
Change to tsx files and run build to make sure it does not throw an error.
There is a change in test added runtime as
anywas implicitly declared as the value type.