Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n issues in the block-switcher component. #48183

Closed
wants to merge 2 commits into from
Closed

Fix i18n issues in the block-switcher component. #48183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08f7fe7
i18n fixes
aristath Feb 17, 2023
726ff12
attempt to fix failing test
aristath Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-mobile-toolbar/test/block-actions-menu.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ describe( 'Block Actions Menu', () => {
// Get Picker title
const pickerHeader = getByRole( 'header' );
const headerTitle = within( pickerHeader ).getByText(
/Transform Paragraph to/
/Transform "Paragraph" to/
);
expect( headerTitle ).toBeVisible();

Expand Down
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/block-switcher/block-transformations-menu.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const BlockTransformationsMenu = ( {
);
const successNotice = sprintf(
/* translators: 1: From block title, e.g. Paragraph. 2: To block title, e.g. Header. */
__( '%1$s transformed to %2$s' ),
__( '"%1$s" transformed to "%2$s"' ),
blockTitle,
selectedItem.label
);
Expand All @@ -82,7 +82,7 @@ const BlockTransformationsMenu = ( {
leftAlign={ true }
getAnchor={ getAnchor }
// translators: %s: block title e.g: "Paragraph".
title={ sprintf( __( 'Transform %s to' ), blockTitle ) }
title={ sprintf( __( 'Transform "%s" to' ), blockTitle ) }
/>
);
};
Expand Down