Block Editor: Improve empty getBlockParents() perf
#48242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
getdave,
jsnajdr,
talldan,
flootr and
ntsekouras
|
Size Change: +5 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8879f41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4230137482
|
There is, however, nothing special about empty array here, is it? Even for non-empty parent arrays, the selector will often return a new array although its contents didn't change. Any change in |
tyxla
force-pushed
the
improve/get-block-parents-empty
branch
from
42fd67e to
8879f41
Compare
Yeah, that's fair to say, but since the reducer works with maps, it would be a completely separate optimization. It would be worth to see if it's being called often enough to require optimization in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the performance of the
getBlockParents()selector, so it will always return the same empty array if no parents are returned.Why?
I've noticed that when the List View is opened, and we're moving with the arrows up and down, extra re-renders are caused because
getBlockParents()returns a different empty array every time.How?
We're simply returning the same empty array when the selector would return an empty array.
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None