Revert Link control UX changes for WP 6.2 #48359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
draganescu,
Mamaduka,
scruffian,
jeryj,
MaggieCabrera,
ajlende and
ntsekouras
getdave
requested review from
kevin940726,
ntwb,
nerrad,
ajitbohra,
ellatrix and
tellthemachines
as code owners
getdave
changed the title
|
Size Change: -66 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e71a3856cab83863c38d7fd38484c3cfde225de3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4252374388
|
ntsekouras
force-pushed
the
revert/link-control-changes
branch
from
e71a385
to
009ff76
Compare
Mamaduka
reviewed
Feb 23, 2023
ntsekouras
approved these changes
Feb 23, 2023
|
@ntsekouras Can we go ahead and merge? Please feel free to do so whenever it's suitable for you as editor tech release leads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some UX/UI changes to Link Control were accidentally included in 6.2 (see #48356 for details). These must now be removed from 6.2 but kept in Gutenberg
trunk.Closes #48356
Why?
See #48356
How?
git revert HASHon all the PRs introduced into Link Control in Gutenberg 15.1.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2023-02-23.at.11-57-04.mp4