Performance: improve focus metric (diff between focus start and type start) #48365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in b848d1d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4254169126
|
ellatrix
force-pushed
the
try/improve-focus-perf-metric-2
branch
from
3ac3602 to
70c1f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related: #48362. Calculates the time difference between the start of
pointerdownandkeydownwhen typing immediately after clicking on a block.Why?
This ensures all events are included that are blocking typing. This makes sure that if we simply move work from e.g. focus to (just an example) click, we don't see a performance improvement while the work is still blocking the next user interaction.
An alternative could be to get the time between the start of
pointerdownand the end of the last relevant event, in this caseclick. We do risk excluding blocking work between that and the next user interaction though.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast