Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote Block: Support Block Switcher #484

Merged
merged 13 commits into from
May 3, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions blocks/api/factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
import uuid from 'uuid/v4';
import { get } from 'lodash';
import { get, castArray, findIndex, isObjectLike } from 'lodash';

/**
* Internal dependencies
Expand All @@ -25,14 +25,15 @@ export function createBlock( blockType, attributes = {} ) {
}

/**
* Switch Block Type and returns the updated block
* Switch a block into one or more blocks of the new block type
*
* @param {Object} block Block object
* @param {string} blockType BlockType
* @return {Object?} Block object
* @return {Array} Block object
*/
export function switchToBlockType( block, blockType ) {
// Find the right transformation by giving priority to the "to" transformation
// Find the right transformation by giving priority to the "to"
// transformation.
const destinationSettings = getBlockSettings( blockType );
const sourceSettings = getBlockSettings( block.blockType );
const transformationsFrom = get( destinationSettings, 'transforms.from', [] );
Expand All @@ -41,13 +42,44 @@ export function switchToBlockType( block, blockType ) {
transformationsTo.find( t => t.blocks.indexOf( blockType ) !== -1 ) ||
transformationsFrom.find( t => t.blocks.indexOf( block.blockType ) !== -1 );

// If no valid transformation, stop. (How did we get here?)
if ( ! transformation ) {
return null;
}

return Object.assign( {
uid: block.uid,
attributes: transformation.transform( block.attributes ),
blockType
let transformationResults = transformation.transform( block.attributes );

// Ensure that the transformation function returned an object or an array
// of objects.
if ( ! isObjectLike( transformationResults ) ) {
return null;
}

// If the transformation function returned a single object, we want to work
// with an array instead.
transformationResults = castArray( transformationResults );

// Ensure that every block object returned by the transformation has a
// valid block type.
if ( transformationResults.some( ( result ) => ! getBlockSettings( result.blockType ) ) ) {
return null;
}

const firstSwitchedBlock = findIndex( transformationResults, ( result ) => result.blockType === blockType );

// Ensure that at least one block object returned by the transformation has
// the expected "destination" block type.
if ( firstSwitchedBlock < 0 ) {
return null;
}

return transformationResults.map( ( result, index ) => {
return {
// The first transformed block whose type matches the "destination"
// type gets to keep the existing block's UID.
uid: index === firstSwitchedBlock ? block.uid : uuid(),
blockType: result.blockType,
attributes: result.attributes
};
} );
}
Loading