Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Per-block script bundles, server enqueues #4841

Closed
wants to merge 1 commit into from

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 2, 2018

Related: #2751, #4514, #2756

This pull request seeks to explore creating individual script bundles for each core block, reverting core registration changes introduced in #4514 while still separating core block registration from the underlying block APIs. The intent here is to work toward core block registration reflecting recommended block enqueueing, also laying a path for server-side block registration for core blocks (#2751) and eventually asynchronous block loading (#2756, #4500 (comment)).

Work-in-progress: The Webpack configuration has been updated to target each block, though could use some refinements particularly in how the global properties are assigned, and filenames of the build distributables generated. Only the paragraph block has been ported to being enqueued by the server-side editor_script handle property. Tests need to be fixed to register core blocks.

@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript [Status] In Progress Tracking issues with work in progress labels Feb 2, 2018
@gziolo gziolo added the [Feature] Extensibility The ability to extend blocks or the editing experience label Feb 3, 2018
@gziolo gziolo self-requested a review February 5, 2018 10:51
@gziolo
Copy link
Member

gziolo commented Feb 5, 2018

I grouped all issues that we need to take into consideration when working on this PR under one column in the Extensibility project.

@kanishkdudeja
Copy link

I'm continuing work on this functionality. I haven't opened a pull request from my fork's branch to this branch yet. I'll do so once the work is nearing completion.

The diff can be viewed at the below link:

update/build-individual-blocks...kanishkdudeja:update/build-individual-blocks

@aduth
Copy link
Member Author

aduth commented May 1, 2018

It's unlikely this could be salvaged with changes made to master in the meantime. Going to close in favor of other pull requests, e.g. 6087 .

@aduth aduth closed this May 1, 2018
@aduth aduth deleted the update/build-individual-blocks branch May 1, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience Framework Issues related to broader framework topics, especially as it relates to javascript [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants