Autocomplete: don't change state on every keystroke #48485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +27 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Feb 27, 2023
There was a problem hiding this comment.
These changes make sense to me, but I'd feel better if @chad1008 could also take a look and test these changes in the editor, given his familiarity with the component.
Also, could you add an entry to the components package's CHANGELOG? Thank you 🙏
|
Flaky tests detected in 477cb19. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4284498135
|
mcsf
reviewed
Feb 27, 2023
tyxla
approved these changes
Feb 27, 2023
ellatrix
force-pushed
the
fix/autocomplete-perf-issue
branch
from
4b28746 to
477cb19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Every time the text changes, we're resetting some state to an empty array, which triggers another re-render.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast