Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify backport status of appearance-tools theme support #48622

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

oandregal
Copy link
Member

Follow-up to #43337

What?

This PR clarifies the status of the appearance-tools theme support by adding a comment and marking the code as experimental, so it's not backported unintentionally.

Why?

The feature missed the 6.1 cycle and was backported in the 6.2 cycle as of https://core.trac.wordpress.org/ticket/56487 However, it had to be reverted as of https://core.trac.wordpress.org/ticket/57649 due to some issues.

How?

Add a comment for people not to backport, following existing practices.

Testing Instructions

Nothing to test. This only adds a comment.

@oandregal oandregal requested a review from spacedmonkey as a code owner March 1, 2023 09:48
@oandregal oandregal self-assigned this Mar 1, 2023
@oandregal oandregal added [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers labels Mar 1, 2023
@oandregal oandregal requested review from jffng, mikachan and pbking March 1, 2023 10:00
@oandregal oandregal merged commit cf132ae into trunk Mar 1, 2023
@oandregal oandregal deleted the update/theme-json-resolver-appearance-tools branch March 1, 2023 10:31
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Mar 1, 2023
@oandregal oandregal added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant