Site Editor Navigation panel: Update appearance of non-link blocks #48933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +247 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Good one! Thank you. Brings it up to date with templates as well:
I think there's a question of why these styles need to be duplicated for both sections, could they have been the same? I.e. the focus styles should be the same across dark material sections. CC: @jorgefilipecosta
|
Thanks for the review. I'll hold on merging, pending a more pragmatic solution.
I suppose it's because the underlying components are different. The Navigation panel uses the off canvas menu editor, which in turn uses the List View components. So it's overrides on overrides 😕 |
|
Why is this better than simply hiding these blocks in this sidebar? |
|
Because if they're hidden you can't re-order them. |
jameskoster
added
Backport to WP 6.7 Beta/RC
|
The Navigation manage will be hidden in WP 6.2, so there's no need to backport this fix. See #49043. |
Mamaduka
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #48675
What?
Updates the interactive behaviours of blocks like Site Logo, Spacer, Social Icons, Search, Custom Link in the Navigation panel.
It also fixes an issue where children of the Page List block had a semi-transparent background applied... see the "Before" video below.
Why?
The current behaviors feel a bit broken. Specifically: when you click one of these blocks they take on a 'selected' appearance (blue background). In this context the 'selected' appearance has no meaning, and leads to confusion.
How?
I did this by basically overriding a bunch of styles attached to the
is-selectedclass. It's not very pretty.I figured it's okay to 'hijack' this class (at least as a short term solution) because in this context there is no concept of 'selecting' a menu item – Page / Post links reveal a drill-down, and the other blocks have no business in being selected.
Sadly I couldn't remove the background applied on hover for these blocks because there is nothing in the markup to identify them.
Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4